Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.25%. Comparing base (bec711b) to head (3b9b9ed).
Report is 5 commits behind head on main.

@@            Coverage Diff             @@
##             main   #15942      +/-   ##
==========================================
+ Coverage   68.23%   68.25%   +0.02%     
==========================================
  Files        1541     1541              
  Lines      197187   197404     +217     
==========================================
+ Hits       134546   134741     +195     
- Misses      62641    62663      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The upgrade of grpc caused some static checks to fail. Muted those in 3b9b9ed.

Failure excerpt:

Error: go/vtbench/client.go:87:24: SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x. (staticcheck)
			return append(opts, grpc.WithBlock()), nil
			                    ^
Error: go/vtbench/client.go:122:24: SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x. (staticcheck)
			return append(opts, grpc.WithBlock()), nil
			                    ^
Error: go/vt/grpcclient/client.go:145:9: SA1019: grpc.DialContext is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
	return grpc.DialContext(ctx, target, newopts...)
	       ^
Error: go/vt/grpcoptionaltls/server_test.go:100:16: SA1019: grpc.DialContext is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
		conn, err := grpc.DialContext(ctx, addr, dialOpt)
		             ^
Error: go/vt/topo/etcd2topo/server.go:144:34: SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x. (staticcheck)
		DialOptions: []grpc.DialOption{grpc.WithBlock()},
		                               ^
Error: go/vt/vtadmin/grpcserver/server_test.go:67:15: SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
	conn, err := grpc.Dial(lis.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithBlock())